Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move payload/builder/src/database.rs to revm/src/cached.rs #12252

Merged
merged 10 commits into from
Nov 1, 2024
Merged

refactor: move payload/builder/src/database.rs to revm/src/cached.rs #12252

merged 10 commits into from
Nov 1, 2024

Conversation

lean-apple
Copy link
Contributor

Closes #12249

mattsse
mattsse requested changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, the clippy/wasm issues are probably coming from std usage.

we can use core::cell instead
and for Hashmap there's alloy_primitives::map which should be no-std

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 1, 2024
@mattsse mattsse marked this pull request as ready for review November 1, 2024 11:05
@mattsse mattsse mentioned this pull request Nov 1, 2024
Merged
@lean-apple
Copy link
Contributor Author

lean-apple commented Nov 1, 2024 •
edited
Loading

cool, the clippy/wasm issues are probably coming from std usage.

we can use core::cell instead and for Hashmap there's alloy_primitives::map which should be no-std

Ah, thanks, I was looking for the solution, testing it now

mattsse
mattsse approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, ty

@mattsse mattsse merged commit c1a68f2 into paradigmxyz:main Nov 1, 2024
41 checks passed
@lean-apple lean-apple deleted the refactor-builder-db-revm-cached branch November 1, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move cachedDb to reth-revm crate
2 participants
@lean-apple @mattsse